star-enclosures-3d

commit e6cbc136945096ce0c9cebcce997e583a545cff1
parent 428f3d13e76bec797dbbf9624ea8ed7513d1cbff
Author: Christophe Coustet <christophe.coustet@meso-star.com>
Date:   Fri, 14 Aug 2020 10:59:15 +0200

Small code change to improve readability

Diffstat:
M
src/senc3d_scene.c
 | 
12
++++++------

1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/senc3d_scene.c b/src/senc3d_scene.c
@@ -142,8 +142,7 @@ senc3d_scene_create
   }
   /* Get triangles */
   FOR_EACH(nt, 0, ntris) {
-    int j, dg;
-    trg_id_t s;
+    int j, dg, s;
     medium_id_t med[2]
       = { SENC3D_UNSPECIFIED_MEDIUM, SENC3D_UNSPECIFIED_MEDIUM };
     vrtx_id_t ind[3];
@@ -182,7 +181,7 @@ senc3d_scene_create
     /* Get media */
     if(media) {
       media(nt, med, ctx);
-      for(s = SENC3D_FRONT; s <= SENC3D_BACK; s += SENC3D_BACK - SENC3D_FRONT) {
+      FOR_EACH(s, 0, 2) {
         if(med[s] == SENC3D_UNSPECIFIED_MEDIUM || med[s] <= MEDIUM_MAX__)
           continue;
         res = RES_BAD_ARG;
@@ -201,7 +200,8 @@ senc3d_scene_create
     /* New triangle */
     ASSERT(nt == htable_trg_size_get(&unique_triangles));
     OK(htable_trg_set(&unique_triangles, &trg_key, &nt));
-    for(s = SENC3D_FRONT; s <= SENC3D_BACK; s += SENC3D_BACK - SENC3D_FRONT) {
+    FOR_EACH(s, 0, 2) {
+      const enum senc3d_side side[2] = { SENC3D_FRONT, SENC3D_BACK };
       struct side_range* media_use;
       size_t m_idx = medium_id_2_medium_idx(med[s]);
       tmp.medium[s] = med[s];
@@ -211,10 +211,10 @@ senc3d_scene_create
       /* media_use 0 is for SENC3D_UNSPECIFIED_MEDIUM */
       media_use = darray_side_range_data_get(&scn->media_use) + m_idx;
       media_use->first =
-        MMIN(media_use->first, TRGIDxSIDE_2_TRGSIDE((trg_id_t)nt, s));
+        MMIN(media_use->first, TRGIDxSIDE_2_TRGSIDE((trg_id_t)nt, side[s]));
       ASSERT(media_use->first < 2 * (scn->ntris + 1));
       media_use->last =
-        MMAX(media_use->last, TRGIDxSIDE_2_TRGSIDE((trg_id_t)nt, s));
+        MMAX(media_use->last, TRGIDxSIDE_2_TRGSIDE((trg_id_t)nt, side[s]));
       ASSERT(media_use->last < 2 * (scn->ntris + 1));
       ASSERT(media_use->first <= media_use->last);
     }