atrstm

commit 91c56475b51d889dcebcf1a84daa9e604fa4325b
parent ccfbfefc573f5f8160772f58591d18be0594b778
Author: Vincent Forest <vincent.forest@meso-star.com>
Date:   Wed, 11 Oct 2023 16:55:21 +0200

Make generated binaries safer and more robust

Define the CFLAGS_HARDENED and LDFLAGS_HARDENED macros, which list
compiler and linker options that activate various hardening features
aimed at increasing the security and robustness of generated binaries.

The link editor options have all been available since at least ld 2.25.
So you don't have to worry about compatibility issues.

The compiler options are in fact some of those that will be enabled by
the -fhardened option to be introduced in GCC 14. In the following, we
list them and indicate the version of GCC from which they are documented
in the manual, i.e. from which version of GCC they would appear to be
available:

  -D_FORTIFY_SOURCE [GCC 5.5]
  -fcf-protection options [GCC 8.5]
  -fstack-protector-strong [GCC 6.5]
  -fstack-clash-protection [GCC 8.5]
  -ftrivial-auto-var-init [GCC 12.3]

The latter, -ftrivial-auto-var-init, is too recent. To avoid any
compatibility problems, we haven't activated it yet.

Diffstat:
M
Makefile
 | 
16
++++++++--------
M
config.mk
 | 
20
++++++++++++++------

2 files changed, 22 insertions(+), 14 deletions(-)
diff --git a/Makefile b/Makefile
@@ -51,7 +51,7 @@ build_library: .config $(DEP)
 $(DEP) $(OBJ): config.mk
 
 $(LIBNAME_SHARED): $(OBJ)
-	$(CC) $(CFLAGS) $(RSYS_CFLAGS) -o $@ $(OBJ) $(LDFLAGS) $(SOFLAGS) $(DPDC_LIBS)
+	$(CC) $(CFLAGS_SO) $(RSYS_CFLAGS) -o $@ $(OBJ) $(LDFLAGS_SO) $(DPDC_LIBS)
 
 $(LIBNAME_STATIC): libatrstm.o
 	$(AR) -rc $@ $?
@@ -81,10 +81,10 @@ libatrstm.o: $(OBJ)
 
 .SUFFIXES: .c .d .o
 .c.d:
-	@$(CC) $(CFLAGS) $(DPDC_CFLAGS) -MM -MT "$(@:.d=.o) $@" $< -MF $@
+	@$(CC) $(CFLAGS_SO) $(DPDC_CFLAGS) -MM -MT "$(@:.d=.o) $@" $< -MF $@
 
 .c.o:
-	$(CC) $(CFLAGS) $(DPDC_CFLAGS) -DATRSTM_SHARED_BUILD -c $< -o $@
+	$(CC) $(CFLAGS_SO) $(DPDC_CFLAGS) -DATRSTM_SHARED_BUILD -c $< -o $@
 
 ################################################################################
 # Installation
@@ -183,17 +183,17 @@ clean_test:
 	$(SHELL) make.sh clean_test $(TEST_SRC)
 
 $(TEST_DEP): config.mk atrstm-local.pc
-	@$(CC) $(CFLAGS) $(RSYS_CFLAGS) $(ATRSTM_CFLAGS) \
+	@$(CC) $(CFLAGS_EXE) $(RSYS_CFLAGS) $(ATRSTM_CFLAGS) \
 	-MM -MT "$(@:.d=.o) $@" $(@:.d=.c) -MF $@
 
 src/test_atrstm.o src/test_atrstm_radcoefs.o: config.mk atrstm-local.pc
-	$(CC) $(CFLAGS) $(RSYS_CFLAGS) $(ATRSTM_CFLAGS) -c $(@:.o=.c) -o $@
+	$(CC) $(CFLAGS_EXE) $(RSYS_CFLAGS) $(ATRSTM_CFLAGS) -c $(@:.o=.c) -o $@
 
 src/test_atrstm_radcoefs_simd.o: config.mk atrstm-local.pc
-	$(CC) $(CFLAGS) $(RSYS_CFLAGS) $(ATRSTM_CFLAGS) $(RSIMD_CFLAGS) -c $(@:.o=.c) -o $@
+	$(CC) $(CFLAGS_EXE) $(RSYS_CFLAGS) $(ATRSTM_CFLAGS) $(RSIMD_CFLAGS) -c $(@:.o=.c) -o $@
 
 test_atrstm test_atrstm_radcoefs: config.mk atrstm-local.pc
-	$(CC) -o $@ src/$@.o $(RSYS_LIBS) $(ATRSTM_LIBS) -lm
+	$(CC) $(CFLAGS_EXE) -o $@ src/$@.o $(LDFLAGS_EXE) $(RSYS_LIBS) $(ATRSTM_LIBS) -lm
 
 test_atrstm_radcoefs_simd: config.mk atrstm-local.pc
-	$(CC) -o $@ src/$@.o $(RSYS_LIBS) $(ATRSTM_LIBS) $(RSIMD_LIBS)
+	$(CC) $(CFLAGS_EXE) -o $@ src/$@.o $(LDFLAGS_EXE) $(RSYS_LIBS) $(ATRSTM_LIBS) $(RSIMD_LIBS)
diff --git a/config.mk b/config.mk
@@ -85,26 +85,34 @@ WFLAGS =\
  -Wmissing-prototypes\
  -Wshadow
 
+CFLAGS_HARDENED =\
+ -D_FORTIFY_SOURCES=2\
+ -fcf-protection=full\
+ -fstack-clash-protection\
+ -fstack-protector-strong
+
 CFLAGS_COMMON =\
  -std=c89\
  -pedantic\
- -fPIC\
  -fvisibility=hidden\
  -fstrict-aliasing\
+ $(CFLAGS_HARDENED)\
  $(WFLAGS)
 
 CFLAGS_RELEASE = -O2 -DNDEBUG $(CFLAGS_COMMON)
 CFLAGS_DEBUG = -g $(CFLAGS_COMMON)
-CFLAGS = $(CFLAGS_$(BUILD_TYPE))
+CFLAGS_SO = $(CFLAGS_$(BUILD_TYPE)) -fPIC
+CFLAGS_EXE = $(CFLAGS_$(BUILD_TYPE)) -fPIE
 
 ################################################################################
 # Linker options
 ################################################################################
-SOFLAGS = -shared -Wl,--no-undefined
+LDFLAGS_HARDENED = -Wl,-z,relro,-z,now
+LDFLAGS_DEBUG = $(LDFLAGS_HARDENED)
+LDFLAGS_RELEASE = -s $(LDFLAGS_HARDENED)
 
-LDFLAGS_DEBUG =
-LDFLAGS_RELEASE = -s
-LDFLAGS = $(LDFLAGS_$(BUILD_TYPE))
+LDFLAGS_SO = $(LDFLAGS_$(BUILD_TYPE)) -shared -Wl,--no-undefined
+LDFLAGS_EXE = $(LDFLAGS_$(BUILD_TYPE)) -pie
 
 OCPFLAGS_DEBUG = --localize-hidden
 OCPFLAGS_RELEASE = --localize-hidden --strip-unneeded